Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiling to wasm #61

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Fix compiling to wasm #61

merged 1 commit into from
Jun 8, 2024
+2 −0

Conversation

kuviman
Copy link
Contributor

@kuviman kuviman commented Jun 7, 2024

Fixes #50

I dont really know if this is correct since I didnt dig too deep into the issue but it does compile and work for me

zeenix
zeenix reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@zeenix zeenix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That easy? :) Thanks. LGTM if @notgull thinks this is correct?

notgull
notgull reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me. I would add a check for WASM to the CI if it's supported by this crate.

@zeenix
Copy link
Member

zeenix commented Jun 8, 2024

Looks alright to me.

Thanks for having a look. 👍

I would add a check for WASM to the CI if it's supported by this crate.

Good point. I'll add that in a separate PR.

@zeenix zeenix merged commit c088cb2 into smol-rs:master Jun 8, 2024
5 checks passed
@mnmaita mnmaita mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull left review comments

@zeenix zeenix zeenix left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiling for wasm32-unknown-unknown fails inside event-listener-strategy
3 participants
@kuviman @zeenix @notgull